Repository navigation
fix(scan): strip query strings from scanned URLs in logs - #136
Open
DevOlabode wants to merge 1 commit into
Open
DevOlabode wants to merge 1 commit into
DevOlabode wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scanned URLs were logged in full, so a scanned reset link or signed URL put its token in the logs. They're now logged as origin and path only. The query string, the
#fragment and anyuser:password@part are all dropped.https://me:pw@site.com/reset?token=abc→https://site.com/resetWhere
scanController.js: the twoReceived … URL:request log lines.scanRunner.js: the structured scan log from feat(scan): structured logging for scans (URL, duration, violations, error class) #130. The redaction runs insidelogScan, so every scan log line gets it.errorfield. Puppeteer's navigation errors quote the full URL (net::ERR_NAME_NOT_RESOLVED at https://…?token=…), so failed scans would still have leaked the token.Both use one small pure module,
services/redactUrl.js:safeUrl(url): origin + path.scrubUrls(text): appliessafeUrlto every URL inside free text.Tests
redactUrl.https://example.comlogs ashttps://example.com/.Not covered: tokens inside the path itself (e.g.
/reset/<token>) are still logged, because the issue asks to keep the path.Closes #132